[webkit-reviews] review granted: [Bug 65493] WebKit2: Web Inspector always starts in undocked mode : [Attachment 102575] [PATCH] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 4 09:36:55 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 65493: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493

Attachment 102575: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=102575&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102575&action=review


> Source/WebCore/inspector/InspectorController.cpp:518
> +void InspectorController::requestAttachWindow()
> +{
> +    if (!m_inspectorFrontendClient)
> +	   return;
> +
> +    m_inspectorFrontendClient->requestAttachWindow();
> +}

Why isn't this function needed in WebKit1?


More information about the webkit-reviews mailing list