[webkit-reviews] review denied: [Bug 65613] ScopedEventQueue should enqueue an EventDispatchMediator : [Attachment 102886] no more parallel structure
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 4 09:01:53 PDT 2011
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 65613: ScopedEventQueue should enqueue an EventDispatchMediator
https://bugs.webkit.org/show_bug.cgi?id=65613
Attachment 102886: no more parallel structure
https://bugs.webkit.org/attachment.cgi?id=102886&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102886&action=review
I like it, but it doesn't go far enough. Be brave, Ito-san! :)
> Source/WebCore/dom/ScopedEventQueue.cpp:70
> void ScopedEventQueue::enqueueEvent(PassRefPtr<Event> event)
> {
> if (m_scopingLevel)
> - m_queuedEvents.append(event);
> +
m_queuedEventDispatchMediators.append(EventDispatchMediator::create(event));
> + else {
> + RefPtr<EventTarget> eventTarget = event->target();
> + eventTarget->dispatchEvent(event);
> + }
> +}
Can we just kill all callsites for this and remove it?
More information about the webkit-reviews
mailing list