[webkit-reviews] review denied: [Bug 65624] [Qt] Make navigation actions properly usable in QML. : [Attachment 102791] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 65624: [Qt] Make navigation actions properly usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=65624

Attachment 102791: Patch
https://bugs.webkit.org/attachment.cgi?id=102791&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102791&action=review


> Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h:46
> +    QWebNavigationController* navigationController;

Look like this is leaked (in both views).
OwnPtr to the rescue? Or add QObject* parent to the constructor of
QWebNavigationController.

> Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.cpp:33
> +

ASSERT(pageProxy) maybe so it fails early in case of mistake?