[webkit-reviews] review denied: [Bug 65612] Web Inspector: draft implementation of source mapping listeners. : [Attachment 102783] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 65612: Web Inspector: draft implementation of source mapping listeners.
https://bugs.webkit.org/show_bug.cgi?id=65612

Attachment 102783: Patch
https://bugs.webkit.org/attachment.cgi?id=102783&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102783&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:125
> +	   this._sourceMappingListeners.push(listener);

Nit: You could do addEventListener(sourceId, listener) followed by a
dispatchEvent(this.sourceId)...

> Source/WebCore/inspector/front-end/ScriptsPanel.js:572
> +	       model.addSourceMappingListener(url, null, formatAnchor);

Could we test anchor update?

> Source/WebCore/inspector/front-end/inspector.js:1323
> +WebInspector._linkifyLocation = function(url, oneBasedLineNumber,
oneBasedColumnNumber, classes, tooltipText, preferredPanel)

Call sites should probably do
WebInspector.debuggerPresentationModel.linkifyLocation(location), where
location is raw 'script' location.

> Source/WebCore/inspector/front-end/inspector.js:1325
> +    if (preferredPanel === "scripts" &&
!WebInspector.debuggerModel.scriptsForURL(url).length)

Either this code or WebInspector._showAnchorLocation should fall back to
"resources".