[webkit-reviews] review denied: [Bug 65551] Web Inspector: use source-file-replaced instead of source-file-changed event. : [Attachment 102667] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 65551: Web Inspector: use source-file-replaced instead of
source-file-changed event.
https://bugs.webkit.org/show_bug.cgi?id=65551

Attachment 102667: Patch
https://bugs.webkit.org/attachment.cgi?id=102667&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102667&action=review


> Source/WebCore/inspector/front-end/ScriptsPanel.js:651
> +	   this._sourceFileIdToFilesSelectOption[newSourceFile.id];

this._sourceFileIdToFilesSelectOption[newSourceFile.id] = option;

Test?

> Source/WebCore/inspector/front-end/ScriptsPanel.js:662
> +	   var newSourceFrame = this._createSourceFrame(newSourceFile.id);

You should keep mapping bind/unbind close in the same location.

> Source/WebCore/inspector/front-end/SourceFile.js:63
> +	       this._resource =
WebInspector.networkManager.inflightResourceForURL(script.sourceURL) ||
WebInspector.resourceForURL(script.sourceURL);

Do we have a test that would track resource / script bindings?