[webkit-reviews] review granted: [Bug 63618] Parsing CSS3 font-feature-settings property : [Attachment 102879] Patch V7

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 63618: Parsing CSS3 font-feature-settings property
https://bugs.webkit.org/show_bug.cgi?id=63618

Attachment 102879: Patch V7
https://bugs.webkit.org/attachment.cgi?id=102879&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102879&action=review


> Source/WebCore/css/CSSParser.cpp:6329
> +    RefPtr<FontFeatureValue> parsedValue =
FontFeatureValue::create(value->string, 1);

Cannot we create this object after the following if-clause? I think we can
eliminate setValue from FontFeatureValue.