[webkit-reviews] review granted: [Bug 10874] lang, xml:lang, content-language ignored when choosing fonts : [Attachment 101929] revised after second review

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Matt Falkenhagen <falken at chromium.org>'s request
for review:
Bug 10874: lang, xml:lang, content-language ignored when choosing fonts
https://bugs.webkit.org/show_bug.cgi?id=10874

Attachment 101929: revised after second review
https://bugs.webkit.org/attachment.cgi?id=101929&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=101929&action=review


r=me but please see the comment below and address if needed.

> Source/WebCore/css/CSSFontSelector.cpp:500
> +	   if (fontDescription.genericFamily() ==
FontDescription::StandardFamily && !fontDescription.isSpecifiedFont())
> +	       return fontDataForGenericFamily(m_document, fontDescription,
"-webkit-standard");

I think you need similar handling in the !m_fontFaces.isEmpty() case that
follows a few lines below. That case would be hit if the document had
@font-face rules but you were still looking at the initial font.