[webkit-reviews] review denied: [Bug 65651] Make sure that AudioArray is 16-byte aligned : [Attachment 102846] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 65651: Make sure that AudioArray is 16-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=65651

Attachment 102846: Patch
https://bugs.webkit.org/attachment.cgi?id=102846&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102846&action=review


Generally looks good but I strongly feel you should be using FastMalloc.h.

> Source/WebCore/platform/audio/AudioArray.h:48
> +	   free(m_allocation);

You should use fastMalloc and fastFree (in <wtf/FastMalloc.h>), as Vector.h
does, to have the possibility of using WebKit's malloc validation, and to crash
upon allocation failure on all platforms.

> Source/WebCore/platform/audio/AudioArray.h:59
> +	       free(m_allocation);

Here too.

> Source/WebCore/platform/audio/AudioArray.h:68
> +	       T* allocation = static_cast<T*>(malloc(sizeof(T) * n +
extraAllocationBytes));

Here too.

> Source/WebCore/platform/audio/AudioArray.h:79
> +		   free(allocation);

Here too.