[webkit-reviews] review granted: [Bug 65641] JSC GC heap size improvement breaks build on some platforms due to unused parameter : [Attachment 102824] the patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 65641: JSC GC heap size improvement breaks build on some platforms due to
unused parameter
https://bugs.webkit.org/show_bug.cgi?id=65641

Attachment 102824: the patch
https://bugs.webkit.org/attachment.cgi?id=102824&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102824&action=review


> Source/JavaScriptCore/heap/Heap.cpp:51
> +    ASSERT_UNUSED(heapSize, heapSize == LargeHeap || heapSize == SmallHeap);


Using ASSERT_UNUSED with an argument that actually is used might cause problems
in the future even if it doesn’t right now. It would be better to structure the
ifdefs so the ASSERT_UNUSED is inside the #else.