[webkit-reviews] review granted: [Bug 65639] Make atomic XML token : [Attachment 102822] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 65639: Make atomic XML token
https://bugs.webkit.org/show_bug.cgi?id=65639

Attachment 102822: Patch
https://bugs.webkit.org/attachment.cgi?id=102822&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102822&action=review


This looks great.  Did you run the parser benchmark?

> Source/WebCore/html/parser/HTMLTokenizer.cpp:51
> +// This has to go in a .cpp file, as the linker doesn't like it being
included more than once.
> +// We don't have an HTMLToken.cpp though, so this is the next best place.

Maybe we should add HTMLToken.cpp?  That seems sort of wasteful for just these
three methods, but there could be more in the future.

> Source/WebCore/xml/parser/MarkupTokenBase.h:377
> +// FIXME: This class should eventually be named HTMLToken once we move the
> +// exiting HTMLToken to be internal to the HTMLTokenizer.

This FIXME should probably be removed.	Turns out making this class internal
isn't worthwhile.

> Source/WebCore/xml/parser/XMLToken.h:436
> +    { }

These should each be on their own line.