[webkit-reviews] review denied: [Bug 65588] Clean up value clamping in CSSStyleSelector. : [Attachment 102735] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 65588: Clean up value clamping in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65588

Attachment 102735: Patch
https://bugs.webkit.org/attachment.cgi?id=102735&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102735&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests / trivial code cleanup only.

This isn’t just code cleanup. It fixes clamping bugs. We need test cases
showing the bad behavior changing to the good behavior. I know it can be
frustrating to see an obvious mistake in the code, easy to fix, and then be
asked to write test cases to show the bug, but this is one of those cases.

> Source/WebCore/css/CSSStyleSelector.cpp:6460
> -		       val = clampToPositiveInteger(val);
> -		       p = Length(static_cast<int>(val), Fixed);
> +		       p = Length(clampToPositiveInteger(val), Fixed);

This one is just code cleanup. The other three are bug fixes.