[webkit-reviews] review granted: [Bug 65547] IndexedDB: Fix index data invalidation bugs. : [Attachment 102758] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Hans Wennborg <hans at chromium.org>'s
request for review:
Bug 65547: IndexedDB: Fix index data invalidation bugs.
https://bugs.webkit.org/show_bug.cgi?id=65547

Attachment 102758: Patch
https://bugs.webkit.org/attachment.cgi?id=102758&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102758&action=review


> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:808
> +static bool findKeyInIndex(LevelDBTransaction* transaction, int64_t
databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey& key,
Vector<char>* foundEncodedPrimaryKey)

Nit: In WebKit, it's more common to use pass by reference for out variables.  I
would change |foundEncodedPrimaryKey| to be consistent with the rest of the
file.