[webkit-reviews] review denied: [Bug 65559] Web Inspector: Pretty print JSONP in network panel preview tab. : [Attachment 102789] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 65559: Web Inspector: Pretty print JSONP in network panel preview tab.
https://bugs.webkit.org/show_bug.cgi?id=65559

Attachment 102789: Patch
https://bugs.webkit.org/attachment.cgi?id=102789&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102789&action=review


Please consider writing a test (both for preview and invalid input data.

> Source/WebCore/inspector/front-end/ResourceJSONView.js:52
> +	   return new WebInspector.ParsedJSON(JSON.parse(text), prefix, "");

Excuse me?

> Source/WebCore/inspector/front-end/ResourceJSONView.js:63
> +    if (start && end) {

start && end for -1 does not work.

> Source/WebCore/inspector/front-end/ResourceJSONView.js:66
> +	   var text = text.substring(start + 1, end);

Consider the following text: ")foo("!

> Source/WebCore/inspector/front-end/ResourceJSONView.js:109
> +    this.postfix = postfix;

suffix