[webkit-reviews] review granted: [Bug 65581] Crash in DocumentWriter::endIfNotLoadingMainResource : [Attachment 102721] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 65581: Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581

Attachment 102721: Patch
https://bugs.webkit.org/attachment.cgi?id=102721&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102721&action=review


> Source/WebCore/ChangeLog:10
> +	   This function is poorly designed because isLoadingMainResource is a
> +	   poor proxy for determing whether to flush/finish the parser. 
Really,
> +	   we should how loads complete to match the model in HTML5, but that's


Typo: I think you're missing a word, "we should change how loads..."?

Also, FIXME in endIfNotLoadingMainResource to this effect?

> LayoutTests/fast/loader/reload-zero-byte-plugin.html:16
> +    }, 100);
> +}, 100);

Can we do this without setTimeout, or with shorter timeouts?  200ms isn't too
bad, but I feel honor-bound to ask.