[webkit-reviews] review denied: [Bug 65616] [GTK] Reorganize header files : [Attachment 102777] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 65616: [GTK] Reorganize header files
https://bugs.webkit.org/show_bug.cgi?id=65616

Attachment 102777: Patch
https://bugs.webkit.org/attachment.cgi?id=102777&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102777&action=review


This patch should probably also add webkitgtk.h to the list of headers skipped
by the style bot.

> GNUmakefile.am:44
> +libwebkitgtkincludedir :=
$(prefix)/include/webkitgtk- at WEBKITGTK_API_VERSION@

libwebkitgtk_include_dir?

> Source/WebKit/gtk/GNUmakefile.am:34
> +# Global header
> +libwebkitgtkinclude_HEADERS += \
> +	$(srcdir)/Source/WebKit/gtk/webkitgtk.h
> +

Is 32libwebkitgtkinclude_HEADERS a primary? I don't see it referenced anywhere
else. What is the significance of the string "libwebkitgtkinclude". I think
this should be next to the other list of headers.

> Source/WebKit/gtk/webkit/webkit.h:21
> +#warning "<webkit/webkit.h> is deprecated, use <webkitgtk.h> instead."

Maybe say  "Including <webkit/webkit.h> is deprecated, include <webkitgtk.h>
directly instead."