[webkit-reviews] review granted: [Bug 65607] Web Inspector: Console scroll position should be saved when switching panels. : [Attachment 102766] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 3 04:44:58 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 65607: Web Inspector: Console scroll position should be saved when
switching panels.
https://bugs.webkit.org/show_bug.cgi?id=65607

Attachment 102766: Patch
https://bugs.webkit.org/attachment.cgi?id=102766&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102766&action=review


> Source/WebCore/inspector/front-end/ConsoleView.js:746
> +	   return this.messagesElement ? this.messagesElement.scrollLeft : 0;

no need to check

> Source/WebCore/inspector/front-end/ConsoleView.js:751
> +	   if (this.messagesElement)

no need to check.

> Source/WebCore/inspector/front-end/ConsoleView.js:757
> +	   return this.messagesElement ? this.messagesElement.scrollTop : 0;

ditto

> Source/WebCore/inspector/front-end/ConsoleView.js:762
> +	   if (this.messagesElement)

ditto


More information about the webkit-reviews mailing list