[webkit-reviews] review granted: [Bug 65600] [GTK] Install web and plugin processes in libexecdir instead of bindir : [Attachment 102757] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 65600: [GTK] Install web and plugin processes in libexecdir instead of
bindir
https://bugs.webkit.org/show_bug.cgi?id=65600

Attachment 102757: Patch
https://bugs.webkit.org/attachment.cgi?id=102757&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102757&action=review


> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:80
> -    GOwnPtr<gchar>
binaryPath(g_build_filename(applicationDirectoryPath().data(),
> +    const gchar* execDirectory = g_getenv("WEBKIT_EXEC_PATH");
> +    GOwnPtr<gchar> binaryPath(g_build_filename(execDirectory ? execDirectory
: LIBEXECDIR,

Eventually we're just going to need to break down and write a cross-platform
method to get the current binary path.