[webkit-reviews] review canceled: [Bug 65595] Support <iframe> in shadow trees : [Attachment 102749] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has canceled Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 65595: Support <iframe> in shadow trees
https://bugs.webkit.org/show_bug.cgi?id=65595

Attachment 102749: Patch
https://bugs.webkit.org/attachment.cgi?id=102749&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102749&action=review


Thank you for reviewing.

> Another idea is to maintain a separate list for shadow frame.

It hink the current idea is better to maintain.  We might want to change the
behavior in the future so that loading for shadow iframes updates the browser
history.

>> Source/WebCore/page/FrameTree.cpp:26

> 
> Is this required?

It's not required.  Removed.

>> Source/WebCore/page/FrameTree.cpp:70
>> +	while (frame->isInShadowTree())
> 
> is fram always non-null?

frame can be null.  But it's safe to call 0->isInShadowTree().

>> Source/WebCore/page/FrameTree.cpp:346
>> +	if (frame)
> 
> Do we need this check?

It's not needed.  frame is always non-0 in this case.
Fixed.

>> Source/WebCore/page/FrameTree.h:55
>> +	    // The number of child frames excluding shadow frames.
> 
> This is obvious from the code.

Removed.