[webkit-reviews] review denied: [Bug 61167] [Chromium] Clicking a named target sets a focus to a previously opened page : [Attachment 102492] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 61167: [Chromium] Clicking a named target sets a focus to a previously
opened page
https://bugs.webkit.org/show_bug.cgi?id=61167

Attachment 102492: Patch
https://bugs.webkit.org/attachment.cgi?id=102492&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102492&action=review


> Source/WebCore/loader/FrameLoader.h:431
> +    bool m_openedBackgroundTab;

How about to mirror navigation policy enum here instead of using enum?
See Source/WebKit/chromium/src/AssertMatchingEnums.cpp to see similar patterns.


> Source/WebKit/chromium/src/FrameLoaderClientImpl.h:255
> +    bool m_openedBackgroundTab;

It looks we don't need this.