[webkit-reviews] review granted: [Bug 65527] WebSocket should be closed by receiving unexpected continuation frame without any leading text or binary frames : [Attachment 102641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 20:38:11 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 65527: WebSocket should be closed by receiving unexpected continuation
frame without any leading text or binary frames
https://bugs.webkit.org/show_bug.cgi?id=65527

Attachment 102641: Patch
https://bugs.webkit.org/attachment.cgi?id=102641&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102641&action=review


Looks ok.

> LayoutTests/ChangeLog:5
> +	   WebSocket: Should be closed by receiving invalid continuation frame.

> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=65527

nit: We don't need a blank line between the summary line and the bug URL.

> Source/WebCore/ChangeLog:5
> +	   WebSocket: Should be closed by receiving invalid continuation frame.

> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=65527

ditto.


More information about the webkit-reviews mailing list