[webkit-reviews] review granted: [Bug 65339] [Qt] [WK2] Expose web view classes to QML : [Attachment 102713] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Caio Marcelo de Oliveira
Filho <cmarcelo at webkit.org>'s request for review:
Bug 65339: [Qt] [WK2] Expose web view classes to QML
https://bugs.webkit.org/show_bug.cgi?id=65339

Attachment 102713: Patch
https://bugs.webkit.org/attachment.cgi?id=102713&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102713&action=review


Looks great

> Source/WebKit2/UIProcess/API/qt/qmlplugin/plugin.cpp:37
> +	   qmlRegisterUncreatableType<QTouchWebPage>(uri, 5, 0, "TouchWebPage",
QString::fromLatin1("Cannot create separate instance of TouchWebPage, use
TouchWebView"));

QString::fromLatin1() -> QObject::tr().