[webkit-reviews] review denied: [Bug 65584] Crash in ResourceResponse::platformCompare() with USE(CFNETWORK) : [Attachment 102718] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Pratik Solanki <psolanki at apple.com>'s
request for review:
Bug 65584: Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
https://bugs.webkit.org/show_bug.cgi?id=65584

Attachment 102718: Patch
https://bugs.webkit.org/attachment.cgi?id=102718&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102718&action=review


> Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:144
> +#if PLATFORM(MAC)
> +    // CFEqual crashes if you pass it 0 and on Mac we can end up with
cfURLResponse() being 0.
> +    if (!a.cfURLResponse() || !b.cfURLResponse())
> +	   return a.cfURLResponse() == b.cfURLResponse();
> +#endif

This should be unconditional, not inside #if PLATFORM(MAC)