[webkit-reviews] review granted: [Bug 65422] Simplify JSFunction creation for functions written in JS : [Attachment 102717] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 17:26:12 PDT 2011


Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 65422: Simplify JSFunction creation for functions written in JS
https://bugs.webkit.org/show_bug.cgi?id=65422

Attachment 102717: Patch
https://bugs.webkit.org/attachment.cgi?id=102717&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
You may want to rename jsName to nameValue per Darin's suggestion, and
functionNameOffset() should probably return a size_t.  Otherwise all looks
good.


More information about the webkit-reviews mailing list