[webkit-reviews] review denied: [Bug 65006] Draw rectangular box shadow for elements with border-radius if no corners are visible : [Attachment 102703] proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ian Henderson
<ianh at apple.com>'s request for review:
Bug 65006: Draw rectangular box shadow for elements with border-radius if no
corners are visible
https://bugs.webkit.org/show_bug.cgi?id=65006

Attachment 102703: proposed patch
https://bugs.webkit.org/attachment.cgi?id=102703&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102703&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:1132
> +static bool cornersIntersect(const RoundedRect& border, const LayoutRect&
clipRect)

I don't think the name of this function is quite right. It's asking whether any
of the rounded corners fall inside the clipRect. You could call it
isAnyCornerVisible() or something. Or you could flip the logic around and call
it allCornersClippedOut().

>
LayoutTests/platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.txt
:4
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600
> +  RenderBlock {HTML} at (0,0) size 800x600

You should make this a dumpAsText(true). Where are the pixel results? If the
pixel result includes a scrollbar, you should refactor the test to avoid this.