[webkit-reviews] review denied: [Bug 65473] [Texmap][Qt] Enable TextureMapperGL in platforms where BGRA is not present : [Attachment 102695] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 65473: [Texmap][Qt] Enable TextureMapperGL in platforms where BGRA is not
present
https://bugs.webkit.org/show_bug.cgi?id=65473

Attachment 102695: Patch
https://bugs.webkit.org/attachment.cgi?id=102695&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Yep, thinking about it, that should really be done on the shader. That way we
avoid adding swapRGB() at all on the texture mapper.

You still did not explain why your assign a ARGB buffer as BGRA. My guess is
because you are targetting little endian so the component are inverted when
assigned in 32 bits compared to passed as byte here??? But in that case you
would have to check the endianess in order to check the format. Am I missing
something? :)