[webkit-reviews] review granted: [Bug 65441] Clean up value clamping in CSSStyleSelector and CSSPrimitiveValue. : [Attachment 102472] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 16:39:31 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 65441: Clean up value clamping in CSSStyleSelector and CSSPrimitiveValue.
https://bugs.webkit.org/show_bug.cgi?id=65441

Attachment 102472: Patch
https://bugs.webkit.org/attachment.cgi?id=102472&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102472&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:4511
> +	   m_style->setOpacity(clampTo<float>(primitiveValue->getDoubleValue(),
0.0, 1.0));

Won't this cause warnings in 64-bit builds? You don't need the .0 on the
literals.


More information about the webkit-reviews mailing list