[webkit-reviews] review granted: [Bug 65578] Add namespace prefix support in XML tokenizer : [Attachment 102707] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 65578: Add namespace prefix support in XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=65578

Attachment 102707: Patch
https://bugs.webkit.org/attachment.cgi?id=102707&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102707&action=review


> Source/WebCore/xml/parser/XMLToken.h:66
> +	   : m_hasStandalone(false)
> +	   , m_hasEncoding(false)
> +	   , m_standalone(false)

Bad indent.  :)

> Source/WebCore/xml/parser/XMLToken.h:206
> +	   m_target.swap(m_data);

Is this a copy?  m_data is stored using inline capacity.  It might be better to
write directly into m_target.