[webkit-reviews] review denied: [Bug 65569] Remove LegacyDefaultOptionalArguments flag from Console.idl : [Attachment 102697] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 15:34:20 PDT 2011


Adam Barth <abarth at webkit.org> has denied Mark Pilgrim <pilgrim at chromium.org>'s
request for review:
Bug 65569: Remove LegacyDefaultOptionalArguments flag from Console.idl
https://bugs.webkit.org/show_bug.cgi?id=65569

Attachment 102697: Patch
https://bugs.webkit.org/attachment.cgi?id=102697&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102697&action=review


> Source/WebCore/page/Console.idl:44
> -	   [V8Custom, CustomArgumentHandling,
ImplementationFunction=assertCondition] void assert(in boolean condition);
> +	   [V8Custom, CustomArgumentHandling,
ImplementationFunction=assertCondition] void assert(in
[Optional=CallWithDefaultValue] boolean condition);

I suspect this attribute doesn't do anything here either because this function
has CustomArgumentHandling.

> Source/WebCore/page/Console.idl:51
> +	   [Custom] void profile(in [Optional=CallWithDefaultValue] DOMString
title);
> +	   [Custom] void profileEnd(in [Optional=CallWithDefaultValue]
DOMString title);

This attribute doesn't do anything for [Custom] bindings.  We can omit it.

> Source/WebCore/page/Console.idl:55
> +	   void time(in
[ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString
title);
> +	   [CustomArgumentHandling] void timeEnd(in
[ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString
title);

This one might need to stay though.  I'm not sure how CustomArgumentHandling
works on V8.


More information about the webkit-reviews mailing list