[webkit-reviews] review canceled: [Bug 65428] dir=auto needs to work on value of input and textarea elements : [Attachment 102584] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 15:32:34 PDT 2011


Yael <yael.aharon at nokia.com> has canceled Yael <yael.aharon at nokia.com>'s
request for review:
Bug 65428: dir=auto needs to work on value of input and textarea elements
https://bugs.webkit.org/show_bug.cgi?id=65428

Attachment 102584: Patch.
https://bugs.webkit.org/attachment.cgi?id=102584&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Added a test for dynamic changes to dir attribute in text form controls, and
added explicit call to calculateAndAdjustDirectionality() from
HTMLInputElement::subtreeHasChanged(), with a check that it is called only for
text fields.

Also broke the line as suggested in comment #2.


More information about the webkit-reviews mailing list