[webkit-reviews] review granted: [Bug 58840] [chromium] Decouple layer visibility calculations from render surfaces / computed draw transforms : [Attachment 102592] fix copyright year

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 58840: [chromium] Decouple layer visibility calculations from render
surfaces / computed draw transforms
https://bugs.webkit.org/show_bug.cgi?id=58840

Attachment 102592: fix copyright year
https://bugs.webkit.org/attachment.cgi?id=102592&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102592&action=review


Overall this looks like good progress. A couple of minor comments. r=me

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:245
>      OwnPtr<CCCanvasLayerImpl::Program> m_canvasLayerProgram;
> +    OwnPtr<CCPluginLayerImpl::Program> m_pluginLayerProgram;
> +    OwnPtr<CCRenderSurface::MaskProgram> m_renderSurfaceMaskProgram;
> +    OwnPtr<CCRenderSurface::Program> m_renderSurfaceProgram;
>      OwnPtr<CCVideoLayerImpl::RGBAProgram> m_videoLayerRGBAProgram;
>      OwnPtr<CCVideoLayerImpl::YUVProgram> m_videoLayerYUVProgram;

It seems to me that these references are abstraction violations. The
LayerRendererChromium shouldn't reference these programs directly. Is there a
plan to move these entirely into the cc/ package? If so, is it worth a FIXME?

> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.h:107
> +    OwnPtr<LayerTexture> m_contentsTexture;

Is this reference an abstraction violation? It seems to me that the
compositor's classes should use those in cc/ but not the other way around.