[webkit-reviews] review granted: [Bug 64536] [EFL] Ignore empty requests on policy decisions. : [Attachment 100821] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Raphael Kubo da
Costa <kubo at profusion.mobi>'s request for review:
Bug 64536: [EFL] Ignore empty requests on policy decisions.
https://bugs.webkit.org/show_bug.cgi?id=64536

Attachment 100821: Patch
https://bugs.webkit.org/attachment.cgi?id=100821&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100821&action=review


As other ports are doing this, I will go ahead and say r+, but maybe it
could/should be fixed elsewhere.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:292
> +
> +    if (resourceRequest.isNull()) {
> +	   callPolicyFunction(function, PolicyIgnore);

Why would this be called when the resource request is empty anyway? I mean,
shouldn't this be fixed elsewhere?