[webkit-reviews] review granted: [Bug 65523] LayoutTests should not declare a global "var undefined; " : [Attachment 102658] Proposed patch (with correct file paths)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 11:40:41 PDT 2011


Adam Barth <abarth at webkit.org> has granted jkummerow at chromium.org's request for
review:
Bug 65523: LayoutTests should not declare a global "var undefined;"
https://bugs.webkit.org/show_bug.cgi?id=65523

Attachment 102658: Proposed patch (with correct file paths)
https://bugs.webkit.org/attachment.cgi?id=102658&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
No one's short circuiting any review process.  There are a couple of questions
here:

1) Should we add a test for this behavior specifically?  None of these tests
appear to be testing this behavior intentionally.
2) Should we change JSC to match Firefox (and shortly V8) in throwing an
exception here.

Neither of these questions need to block this patch.


More information about the webkit-reviews mailing list