[webkit-reviews] review granted: [Bug 65549] Web Inspector: remove Node parameter from the InspectorClient::highlight : [Attachment 102666] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 10:41:29 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 65549: Web Inspector: remove Node parameter from the
InspectorClient::highlight
https://bugs.webkit.org/show_bug.cgi?id=65549

Attachment 102666: Patch
https://bugs.webkit.org/attachment.cgi?id=102666&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102666&action=review


> Source/WebCore/inspector/InspectorClient.h:47
> +    virtual void highlight() = 0;

Now that there is no Node parameter, I think we should rename the method to
something that would better reflect it purpose and start with a verb, probably
drawHighlight?


More information about the webkit-reviews mailing list