[webkit-reviews] review denied: [Bug 65200] CSS Regions build bot should archive and upload output files : [Attachment 102644] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 65200: CSS Regions build bot should archive and upload output files
https://bugs.webkit.org/show_bug.cgi?id=65200

Attachment 102644: Patch
https://bugs.webkit.org/attachment.cgi?id=102644&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102644&action=review


Just a couple of cosmetic issues this time. Looks great!

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:262
>			 "platform": "mac-snowleopard", "configuration":
"release", "architectures": ["x86_64"], "features": ["css-regions",
"css-exclusions"],
> -			 "slavenames": ["adobe-mac-slave1"]
> +			 "upload": true, "slavenames": ["adobe-mac-slave1"]

I'd recommend putting "upload": true on its own line above "slavenames".

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:135
> +				   extraFeatures=lambda
properties:UploadBuiltProduct.determineExtraFeatures(properties))

Missing a space after the colon.