[webkit-reviews] review granted: [Bug 65523] LayoutTests should not declare a global "var undefined; " : [Attachment 102628] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 02:45:41 PDT 2011


Adam Barth <abarth at webkit.org> has granted jkummerow at chromium.org's request for
review:
Bug 65523: LayoutTests should not declare a global "var undefined;"
https://bugs.webkit.org/show_bug.cgi?id=65523

Attachment 102628: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=102628&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks fine, but the patch isn't based in the correct directory, so we
won't be able to land this patch automatically.  Please see these instructions
for preparing patches:

http://www.webkit.org/coding/contributing.html

If you're using a Chromium checkout, you might not be able to create correct
WebKit patches.  Please see http://www.webkit.org/building/checkout.html for
instructions on creating a WebKit working copy.

Thanks for the patch.


More information about the webkit-reviews mailing list