[webkit-reviews] review granted: [Bug 65468] Web Inspector: _normalizeEventTypes (via console's monitorEvents) doesnt handle all events like 'search' and other atypical ones. : [Attachment 102517] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 00:59:31 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 65468: Web Inspector: _normalizeEventTypes (via console's monitorEvents)
doesnt handle all events like 'search' and other atypical ones.
https://bugs.webkit.org/show_bug.cgi?id=65468

Attachment 102517: Patch
https://bugs.webkit.org/attachment.cgi?id=102517&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102517&action=review


> Source/WebCore/inspector/InjectedScriptSource.js:664
> +	       types = [ "mouse", "key", "control", "load", "unload", "abort",
"error", "select", "change", "submit", "reset", "focus", "blur", "resize",
"scroll", "search", "devicemotion", "deviceorientation" ];

Please remove control events from this list as they are declared below.


More information about the webkit-reviews mailing list