[webkit-reviews] review denied: [Bug 65436] Use threadsafeCopy() API when using Database Directory path variable : [Attachment 102468] patch file

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Srikumar B <srikumar.b at gmail.com>'s
request for review:
Bug 65436: Use threadsafeCopy() API when using Database Directory path variable
https://bugs.webkit.org/show_bug.cgi?id=65436

Attachment 102468: patch file
https://bugs.webkit.org/attachment.cgi?id=102468&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102468&action=review


> Source/WebCore/ChangeLog:8
> +	   Use threadsafeCopy() API when using m_databaseDirectoryPath string
variable

when the databaseGuard lock hasn't been taken

> Source/WebCore/storage/DatabaseTracker.cpp:105
> +    return
SQLiteFileSystem::appendDatabaseFileNameToPath(m_databaseDirectoryPath.threadsa
feCopy(), "Databases.db");

This one seems good.

> Source/WebCore/storage/DatabaseTracker.cpp:820
> +	     
SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_databaseDirectoryPath.threadsa
feCopy());

This seems unnecessary since the lock m_databaseGuard has been taken.