[webkit-reviews] review granted: [Bug 65418] webkit-patch needs to be able to "optimize" the storage of baselines on disk : [Attachment 102581] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 65418: webkit-patch needs to be able to "optimize" the storage of baselines
on disk
https://bugs.webkit.org/show_bug.cgi?id=65418

Attachment 102581: Patch
https://bugs.webkit.org/attachment.cgi?id=102581&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102581&action=review


> Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py:52
> +def _invert_dictionarty(dictionary):

did you mean to suffix it with "arty"? I mean, it's pretty arty, but just want
to make sure.

> Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:47
> +class BaselineOptimizerTest(unittest.TestCase):

The tests seems skimpy, given the glorious complexity of the code above.