[webkit-reviews] review granted: [Bug 61346] --webkit-visual-word: ctrl-arrow is not able to reach the boundary of line : [Attachment 102565] Revised fix (with updated test cases)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 1 15:11:45 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Van Lam <vanlam at google.com>'s
request for review:
Bug 61346: --webkit-visual-word: ctrl-arrow is not able to reach the boundary
of line
https://bugs.webkit.org/show_bug.cgi?id=61346

Attachment 102565: Revised fix (with updated test cases)
https://bugs.webkit.org/attachment.cgi?id=102565&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102565&action=review


> Source/WebCore/editing/visible_units.cpp:1368
> +static void appendEndOfLinePosition(const InlineBox* box,
WordBoundaryVector& orderedWordBoundaries)

appendPositionAtLogicalEndOfLine?  EndOfLinePosition sounds funny.


More information about the webkit-reviews mailing list