[webkit-reviews] review granted: [Bug 65411] Web Inspector: merge FormattedSourceFile into SourceFile. : [Attachment 102435] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 1 09:55:45 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 65411: Web Inspector: merge FormattedSourceFile into SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65411

Attachment 102435: Patch
https://bugs.webkit.org/attachment.cgi?id=102435&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102435&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:33
> +    this._formatter = new WebInspector.ScriptFormatter();

Please add fixme suggesting that formatter is applied from outside as a generic
mapping.


More information about the webkit-reviews mailing list