[webkit-reviews] review granted: [Bug 65092] Don't set m_fontDirty when setting zoom unless zoom has actually changed : [Attachment 102479] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 65092: Don't set m_fontDirty when setting zoom unless zoom has actually
changed
https://bugs.webkit.org/show_bug.cgi?id=65092

Attachment 102479: Patch
https://bugs.webkit.org/attachment.cgi?id=102479&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102479&action=review


> Source/WebCore/rendering/style/RenderStyle.h:963
> +    bool setZoom(float f)
> +    {
> +	   if (compareEqual(visual->m_zoom, f))
> +	       return false;
> +	   visual.access()->m_zoom = f;
> +	   setEffectiveZoom(effectiveZoom() * zoom());
> +	   return true;
> +    }
> +    void setZoomWithoutReturnValue(float f) { setZoom(f); }
> +    bool setEffectiveZoom(float f)
> +    {
> +	   if (compareEqual(rareInheritedData->m_effectiveZoom, f))
> +	       return false;
> +	   rareInheritedData.access()->m_effectiveZoom = f;
> +	   return true;
> +    }

Now that these function bodies are long, it might be worthwhile to put them
outside the class definition, so you can read class definition more easily.