[webkit-reviews] review denied: [Bug 64263] libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed : [Attachment 102522] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 1 09:09:52 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 64263: libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL'
failed
https://bugs.webkit.org/show_bug.cgi?id=64263

Attachment 102522: proposed patch
https://bugs.webkit.org/attachment.cgi?id=102522&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102522&action=review


> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:708
> +    if ((soupMessage->status_code == SOUP_STATUS_NONE) ||
(soupMessage->status_code ==SOUP_STATUS_OK))

You are missing a space after the second ==. Shouldn't it be != too?


More information about the webkit-reviews mailing list