[webkit-reviews] review denied: [Bug 65311] [EFL] Replace strerror with strerror_r. : [Attachment 102247] Patch

[bugzilla-daemon at webkit.org]

Lucas De Marchi <demarchi at webkit.org> has denied KwangHyuk
<hyuki.kim at samsung.com>'s request for review:
Bug 65311: [EFL] Replace strerror with strerror_r.
https://bugs.webkit.org/show_bug.cgi?id=65311

Attachment 102247: Patch
https://bugs.webkit.org/attachment.cgi?id=102247&action=review

------- Additional Comments from Lucas De Marchi <demarchi at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102247&action=review


> Source/WebKit/efl/ewk/ewk_tiled_private.h:35
> +#define OOM(op, size) \
> +    char buf[256]; \
> +    CRITICAL("could not %s %zd bytes: %s", op, size, strerror_r(errno, buf,
sizeof(buf)))
> +

Besides what Raphael said, this is wrong. See this piece of code:

int function(void)
{
    char *buf;

    buf = malloc(200);
    if (!buf)
	OOM("allocate", 200);
}


Bang... you get a compiler error: `error: expected expression before ‘char’'