[webkit-reviews] review granted: [Bug 59856] Plug-in failed to initialize message should be called when Java fails to initialize : [Attachment 91784] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 30 03:05:41 PDT 2011


Maciej Stachowiak <mjs at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 59856: Plug-in failed to initialize message should be called when Java
fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59856

Attachment 91784: Patch
https://bugs.webkit.org/attachment.cgi?id=91784&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91784&action=review

r=me

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1257
> +    const String mimeType = "application/x-java-applet";

I suggest naming this javaMimeType or appletMimeType or something like that.


More information about the webkit-reviews mailing list