[webkit-reviews] review denied: [Bug 59797] Web Inspector: [STYLES] Lazily build computed trace to speed up switching between elements in the Elements panel : [Attachment 91697] [PATCH] Suggested solution
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 30 02:24:08 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 59797: Web Inspector: [STYLES] Lazily build computed trace to speed up
switching between elements in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=59797
Attachment 91697: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=91697&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91697&action=review
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:515
> + section.expanded = this._computedStylePane.expanded;
style rule sections should never be collapsed. if you fine one that is, please
fix it in its constructor.
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:519
> + section.expanded = true;
ditto
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:667
> + if (!this.section.expanded)
ditto
More information about the webkit-reviews
mailing list