[webkit-reviews] review granted: [Bug 59846] Scrolling causes rounded bottom window corners to become square : [Attachment 91774] Patch that addresses Simon's comments

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 59846: Scrolling causes rounded bottom window corners to become square
https://bugs.webkit.org/show_bug.cgi?id=59846

Attachment 91774: Patch that addresses Simon's comments
https://bugs.webkit.org/attachment.cgi?id=91774&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91774&action=review

> Source/WebKit2/UIProcess/API/mac/PageClientImpl.h:127
> +    NSRect m_windowBottomCornerIntersectionRect;

This is unused?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:933
> +    BOOL maskWindow = window &&
!NSIsEmptyRect(_data->_windowBottomCornerIntersectionRect);

Would read better if this was shouldMaskWindow