[webkit-reviews] review denied: [Bug 59070] [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method : [Attachment 91603] patch v3, using dynamic property

[bugzilla-daemon at webkit.org]

Luiz Agostini <luiz at webkit.org> has denied Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>'s request for review:
Bug 59070: [Qt] Fix QNetworkReplyWrapper to not depend on
QNetworkReply::isFinished() method
https://bugs.webkit.org/show_bug.cgi?id=59070

Attachment 91603: patch v3, using dynamic property
https://bugs.webkit.org/attachment.cgi?id=91603&action=review

------- Additional Comments from Luiz Agostini <luiz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91603&action=review

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:663
> -    if (m_loadType == SynchronousLoad &&
m_replyWrapper->reply()->isFinished()) {
> +    if (m_loadType == SynchronousLoad && m_replyWrapper->isFinished()) {
>	   m_replyWrapper->synchronousLoad();
>	   // If supported, a synchronous request will be finished at this
point, no need to hook up the signals.
>	   return;

For synchronous requests we should call m_replyWrapper->synchronousLoad() and
return anyway.
My suggestion now is that we do not check for isFinished at this point and that
we call QNetworkReplyWrapper::setFinished() from
QNetworkReplyWrapper::synchronousLoad().
Then we may avoid using QNetworkReply::isFinished() completely.

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:84
> +    bool isFinished() const { return m_reply->isFinished() ||
m_reply->property("_q_isFinished").toBool(); }

How can we trust on QNetworkReply::isFinished()? We should have a solution that
does not rely on it.

> Source/WebCore/platform/network/qt/QtMIMETypeSniffer.h:44
> +    bool isReplyFinished() const { return m_reply->isFinished() ||
m_reply->property("_q_isFinished").toBool(); }

The same here.