[webkit-reviews] review granted: [Bug 59604] REGRESSION: r83938 abandons GC memory : [Attachment 91745] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 59604: REGRESSION: r83938 abandons GC memory
https://bugs.webkit.org/show_bug.cgi?id=59604

Attachment 91745: Patch
https://bugs.webkit.org/attachment.cgi?id=91745&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91745&action=review

> Source/WebCore/bindings/js/JSNodeCustom.cpp:108
>	   // If a wrapper is the last reference to an image or script element

Please fix the comment, too.

> Source/WebCore/loader/ImageLoader.cpp:70
> +    bool hasPendingEvents(const ImageLoader* loader) { return
m_dispatchSoonList.find(loader) != notFound; }

We don't normally use const with complex classes. In particular, "const
ImageLoader" never appears in WebCore code now.

So, I would slightly prefer removing "const" from
ImageLoader::hasPendingLoadEvent() instead.

> LayoutTests/fast/dom/gc-image-element.html:17
> +function gc()

You could also use js-test machinery for logging and gc().