[webkit-reviews] review granted: [Bug 59721] REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs : [Attachment 91717] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Jon Lee <jonlee at apple.com>'s request for review:
Bug 59721: REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs
https://bugs.webkit.org/show_bug.cgi?id=59721

Attachment 91717: Patch
https://bugs.webkit.org/attachment.cgi?id=91717&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=91717&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:349
> +WK_EXPORT void WKPageSetMaintainsInactiveSelection(WKPageRef page, bool);

In these C API headers, we usually name all parameters, including booleans.
Please call this one “maintainsInactiveSelection” or something.

> Source/WebKit2/UIProcess/WebPageProxy.h:258
> +    void setMaintainsInactiveSelection(bool newValue);

No need for the name here, though!