[webkit-reviews] review granted: [Bug 59149] (Regression) Existing animations are not replaced when filling. : [Attachment 91698] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 59149: (Regression) Existing animations are not replaced when filling.
https://bugs.webkit.org/show_bug.cgi?id=59149

Attachment 91698: Patch
https://bugs.webkit.org/attachment.cgi?id=91698&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91698&action=review

r=me but please consider improving the pixel test.

> LayoutTests/animations/3d/replace-filling-transform.html:78
> +This sets up two animations. It runs the first and then triggers the 2nd.
The first fills
> +forwards, but should still be replaced by the second. The first is a
horizontal animation, the second is
> +vertical, so the box should end up translated vertically down the page.

Please put this text into an HTML comment, so that it doesn't show in the pixel
result. That way, the result can be cross-platform.

Also, make #result have opacity: 0 so it doesn't pollute the pixel result.

For extra points, make the test box a 100x100px green square, and put a red
square under its correct end position. Then when the test fails, red will be
visible.

If you've done all this, the pixel result can then be platform-agnostic and go
into LayoutTests/animations/3d